myGrid

Allow overriding MyGridConfiguration properties on command line

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 2.0 essential
  • Component/s: Taverna Core
  • Labels:
    None

Description

Taverna properties (from mygrid.properties) are read by MyGridConfiguration. It is not possible to override these on the command line with -Dtaverna.something=fish. Currently we are abusing the export of existing entries by loadMyGridProperties() to System properties to allow taverna.dotlocation to be set on both the command line and in the property file.

A fix for this has been suggested in TAV-267.

From TAV-267:

Note that taverna.dotlocation is read as a system properties instead of MyGridConfiguration.getProperty() by ScuflSVGDiagram and ScuflDiagramPanel.

This is to support setting taverna.dotlocation on the commandline, as now done in Windows (runme.bat) and in OS X (Taverna.app/blah/blah/Info.plist).

A better fix would be to let MyGridConfiguration.getProperties() to read overriden properties from system properties, like we do with raven.properties in Bootstrap. However, this causes a challenge as currently the MyGrid properties are also exported as system properties by loadMyGridProperties() for backward compatibility.

Possibly Graphviz should be an artifact with binaries included for known OS-es (also Linux), unpacked to some location (like .taverna/lib/graphviz), and run from there.

So to fix this we would probably also have to get away with existing System.getProperty("taverna.something") calls, and replace them with MyGridConfiguration.getProperty("taverna.something") - which should not cause any problems, as long as we also implement the overriding thing.

Issue Links

Activity

Hide
Ian Dunlop added a comment - 2008-03-26 10:57

All the property type stuff should be sorted for T2, it seems to cause no end of problems.

Show
Ian Dunlop added a comment - 2008-03-26 10:57 All the property type stuff should be sorted for T2, it seems to cause no end of problems.

People

Vote (0)
Watch (0)

Dates

  • Created:
    2006-11-20 14:38
    Updated:
    2008-04-02 11:34