myGrid

XML viewer "die" with no response on faulty XML

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.4
  • Fix Version/s: 1.5.1
  • Component/s: Taverna GUI
  • Labels:
    None

Description

Following email from Duncan Hull on taverna-users 2006-10-11, the attached workflow is an example of where a processor producing "XML" that is not valid, say forgetting some </closing> tags. When viewing the results, and "Click to see more.." - nothing seems to happen, as the default XML viewer dies on this input. However, right clicking and selecting "View as Text" works.

There should be an error message if the XML is not parsable, and a suggestion to try text-view instead.

Activity

Hide
Stian Soiland-Reyes added a comment - 2007-01-08 09:59

TextXML handler fixed, it now tries to parse the document in canHandle method, so that it refuses to handle non-parsable messages.

Error dialogues appear if a RendererException occurs in ResultItemPanel, in case another viewer plugin fails in a similar way, at least a message is shown to the user instead of the previous no-op.

ResultItemPanel has been refactored a bit so that it should be easier to do future improvements to the result views.

Show
Stian Soiland-Reyes added a comment - 2007-01-08 09:59 TextXML handler fixed, it now tries to parse the document in canHandle method, so that it refuses to handle non-parsable messages. Error dialogues appear if a RendererException occurs in ResultItemPanel, in case another viewer plugin fails in a similar way, at least a message is shown to the user instead of the previous no-op. ResultItemPanel has been refactored a bit so that it should be easier to do future improvements to the result views.

People

Vote (1)
Watch (0)

Dates

  • Created:
    2006-10-12 10:16
    Updated:
    2007-01-08 09:59
    Resolved:
    2007-01-08 09:59