[#TAV-165] Several workflow instances created - myGrid

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.4, 1.5
Fix Version/s: 1.5
Component/s: Taverna Core, Taverna Enactor
Labels:
None

Description

Duplicate WorkflowInstance instances are created when running a workflow, one for each processor run.

This causes problems when assigning LSIDs to a workflow instance (ie. a run), involving ~~TAV-153~~, ~~TAV-59~~, ~~TAV-160~~.

The proposed fix is to make sure only one instance is created and passed along correctly, which might require some slight refactoring.

Issue Links

Depends

This issue has dependent:
~~TAV-153~~ Error from workflow id = 0
~~TAV-160~~ CollectionConstructionEvent has workflowInstance with no id.
~~TAV-59~~ Store per-process

This issue related to:
~~TAV-156~~ EnactorInvocation.detachFromModel() might destroy workflow instances too soon.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Stian Soiland-Reyes added a comment - 2006-11-07 12:08

Fixed by having a cache in WorkflowInstance.getInstance(). The instances are removed from the cache on destroy(). See ~~TAV-156~~.

Show

Stian Soiland-Reyes added a comment - 2006-11-07 12:08 Fixed by having a cache in WorkflowInstance.getInstance(). The instances are removed from the cache on destroy(). See ~~TAV-156~~.

Hide

Permalink

Stian Soiland-Reyes added a comment - 2006-11-07 12:09

Also cleared up the getID() and getDefinitionLSID() code to avoid using those Map's.

Show

Stian Soiland-Reyes added a comment - 2006-11-07 12:09 Also cleared up the getID() and getDefinitionLSID() code to avoid using those Map's.

Hide

Permalink

Daniele Turi added a comment - 2006-11-13 15:13

Cache Key in WorkflowInstanceId does not work, because based on array, which has a new hashcode every time.

Solution Change to List.

Show

Daniele Turi added a comment - 2006-11-13 15:13 Cache Key in WorkflowInstanceId does not work, because based on array, which has a new hashcode every time. Solution Change to List.

Hide

Permalink

Daniele Turi added a comment - 2006-11-13 15:15

Cache key solution implemented.

Show

Daniele Turi added a comment - 2006-11-13 15:15 Cache key solution implemented.

People

Assignee:

Stian Soiland-Reyes

Reporter:

Stian Soiland-Reyes

Vote (0)

Watch (0)

Dates

Created:

2006-09-26 11:50

Updated:

2006-11-13 15:15

Resolved:

2006-11-13 15:15